Skip to content

Fix preprocessing leaves unnecessary lifetimes#75

Merged
RoDmitry merged 9 commits intotypesense:mainfrom
haydenhoang:main
Mar 20, 2026
Merged

Fix preprocessing leaves unnecessary lifetimes#75
RoDmitry merged 9 commits intotypesense:mainfrom
haydenhoang:main

Conversation

@haydenhoang
Copy link
Contributor

@haydenhoang haydenhoang commented Mar 17, 2026

Change Summary

This PR made changes to the preprocessing script to fix issue #65.

Only request models and models in this list are made to use Cow, not models that are BOTH request and response.

PR Checklist

@haydenhoang
fix: autogenerated structures with unused lifetimes
21122cd 
Fixed typesense#65

Only request models and models whose name ending with `Parameters` are made to use Cow.
@haydenhoang
run clippy fix
06427cf
@haydenhoang
force borrow model based on explicit names instead of name ending wit…
acec54f 
…h "Parameters"
@RoDmitry
Copy link
Collaborator

RoDmitry commented Mar 17, 2026

Looks good. But I guess the meaning of x-rust-has-borrowed-data has changed. Previously it was mainly set to objects which contained strings, but what does it mean now? Why is it set to each string? Maybe rename so it would be meaningful?

RoDmitry
RoDmitry reviewed Mar 17, 2026
View reviewed changes
@RoDmitry
Copy link
Collaborator

RoDmitry commented Mar 18, 2026

Still does not look right:
https://github.com/haydenhoang/typesense-rust/blob/693c567711cb5bb988ae29b359e9a7b8dccc4d06/preprocessed_openapi.yml#L101
https://github.com/haydenhoang/typesense-rust/blob/693c567711cb5bb988ae29b359e9a7b8dccc4d06/preprocessed_openapi.yml#L174
https://github.com/haydenhoang/typesense-rust/blob/693c567711cb5bb988ae29b359e9a7b8dccc4d06/preprocessed_openapi.yml#L203
https://github.com/haydenhoang/typesense-rust/blob/693c567711cb5bb988ae29b359e9a7b8dccc4d06/preprocessed_openapi.yml#L604
and many more.

Is it used at all when set to a string type?
If so, maybe rename to something like x-rust-has-lifetime for example, which would be easier to understand.

RoDmitry
RoDmitry requested changes Mar 18, 2026
View reviewed changes
RoDmitry
RoDmitry reviewed Mar 19, 2026
View reviewed changes
@haydenhoang
Copy link
Contributor Author

haydenhoang commented Mar 19, 2026 •
edited
Loading

I have removed the remaining unnecessary flags and also changed the name to x-rust-has-lifetime.

Edit: wait, look like there are still some unnecessary flags left, let me take a look...

@haydenhoang
Copy link
Contributor Author

haydenhoang commented Mar 20, 2026

Done.

@haydenhoang haydenhoang requested a review from RoDmitry March 20, 2026 05:44
@RoDmitry RoDmitry merged commit 093c7b3 into typesense:main Mar 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RoDmitry RoDmitry RoDmitry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haydenhoang @RoDmitry